Repository navigation
Fix port offset cutting off text after the port - #48463
Merged
Merged
Conversation
jkarneges
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When applying
port_offsetto atcp://address,SettingspassedQString::replace()the port's end position instead of its length, so it also deleted text after the port. For example, with aport_offsetof 1,tcp://host:5560/abcdefghijklmnopbecametcp://host:5561klmnop. Addresses that end at the port aren't affected.This change passes the port's length instead, and continues searching after the new port.
Tested locally